Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read env var to compile custom service definitions #18

Merged
merged 2 commits into from
Sep 19, 2024

Conversation

VoreckLukas
Copy link
Contributor

This should resolve #13.
The build script reads the KRPC_SERVICES env var and if it exists use that directory to look for service definitions to compile.
This still needs to be documented in the readme but I'm unsure where

@kladd
Copy link
Owner

kladd commented Sep 18, 2024

I could see a section after "Using streams" called "Using custom service definitions" or something like that. Another doc that comes to mind for doing this is the openssl crate. That format seems reasonable.

@VoreckLukas VoreckLukas marked this pull request as ready for review September 19, 2024 04:24
@VoreckLukas
Copy link
Contributor Author

I'll leave stuff like incrementing version numbers to you

@kladd kladd merged commit 1b2bab4 into kladd:master Sep 19, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow building with local service definitions
2 participants