Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(exex): add rollup ExEx to reexecute blocks on notif #4

Merged
merged 12 commits into from
Jul 25, 2024
Merged

feat(exex): add rollup ExEx to reexecute blocks on notif #4

merged 12 commits into from
Jul 25, 2024

Conversation

tcoratger
Copy link
Contributor

@tcoratger tcoratger commented Jul 24, 2024 •
edited
Loading

Should close #8.

tcoratger
tcoratger commented Jul 24, 2024
View reviewed changes
.gitignore Outdated Show resolved Hide resolved
tcoratger
tcoratger commented Jul 24, 2024
View reviewed changes
Cargo.toml Show resolved Hide resolved
crates/exex/src/db.rs Outdated Show resolved Hide resolved
crates/exex/src/exex.rs Show resolved Hide resolved
greged93
greged93 reviewed Jul 25, 2024
View reviewed changes
Copy link
Contributor

@greged93 greged93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think my big comment here is that I don't really like the fact that we are adding so much code that we are potentially deleting in two PR's once we had the cairo-vm execution for example

Cargo.toml Outdated Show resolved Hide resolved
crates/exex/src/db.rs Outdated Show resolved Hide resolved
crates/exex/src/exex.rs Show resolved Hide resolved
crates/exex/src/exex.rs Show resolved Hide resolved
crates/exex/src/db.rs Show resolved Hide resolved
greged93
greged93 reviewed Jul 25, 2024
View reviewed changes
crates/exex/src/db.rs Outdated Show resolved Hide resolved
crates/exex/src/db.rs Outdated Show resolved Hide resolved
crates/exex/src/db.rs Outdated Show resolved Hide resolved
greged93
greged93 reviewed Jul 25, 2024
View reviewed changes
crates/exex/src/db.rs Outdated Show resolved Hide resolved
@greged93 greged93 added this pull request to the merge queue Jul 25, 2024
Merged via the queue into kkrt-labs:main with commit e618bfb Jul 25, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greged93 greged93 greged93 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add simple Exex example which logs the transaction hashes from a block.
2 participants
@tcoratger @greged93