Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add dipdup guide to ecosystem section in the docs #23

Merged
merged 4 commits into from
Apr 10, 2024
Merged

feat: add dipdup guide to ecosystem section in the docs #23

merged 4 commits into from
Apr 10, 2024

Conversation

Wizard1209
Copy link
Contributor

No description provided.

Eikix
Eikix reviewed Apr 9, 2024
View reviewed changes
Copy link
Member

@Eikix Eikix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi thanks a lot for the PR!

Was this tested locally, does this work?

Also, about folder structure, we should make the data indexers a folder, just like the ecosystem, and nest dipdup inside of it!

@Wizard1209
Copy link
Contributor Author

Hi @Eikix
The entire scenario was tested locally, so yes
I made new folder Data indexers with DipDup guide, check it out

@Eikix
Copy link
Member

Eikix commented Apr 10, 2024

Hi I just proposed a new folder structure, let me know if it's fine for you

@Wizard1209
Copy link
Contributor Author

Great!

@Wizard1209 Wizard1209 requested a review from Eikix April 10, 2024 20:54
Eikix
Eikix approved these changes Apr 10, 2024
View reviewed changes
Copy link
Member

@Eikix Eikix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Eikix Eikix merged commit 4eebcd8 into kkrt-labs:main Apr 10, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Eikix Eikix Eikix approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Wizard1209 @Eikix