Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly detect the number of article for zim version <= 6 #743

Merged
merged 1 commit into from
Apr 6, 2022

Conversation

mgautierfr
Copy link
Member

@codecov
Copy link

codecov bot commented Apr 4, 2022

Codecov Report

Merging #743 (85a9d35) into master (a17258f) will increase coverage by 0.08%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #743      +/-   ##
==========================================
+ Coverage   60.47%   60.55%   +0.08%     
==========================================
  Files          56       56              
  Lines        3724     3732       +8     
  Branches     2058     2061       +3     
==========================================
+ Hits         2252     2260       +8     
  Misses       1471     1471              
  Partials        1        1              
Impacted Files Coverage Δ
src/book.cpp 86.66% <100.00%> (ø)
src/tools/archiveTools.cpp 87.01% <100.00%> (+1.50%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a17258f...85a9d35. Read the comment docs.

@kelson42
Copy link
Collaborator

kelson42 commented Apr 4, 2022

@mgautierfr I don't think this is proper. We need to reintroduce the media and article count based on M/Counter... this is what was done earlier.

@mgautierfr
Copy link
Member Author

This is what is done with (old) zim files (<=6). For new zim files, we use the list of front articles (the same on which we do random or title suggestion).
Using the front articles list is probably more accurate as we don't count text/html items with are html redirects (warc2zim).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

library_zim.xml and root.xml show incorrect articleCount for recent ZIM files
3 participants