New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate CleanupConfig when building ErrorContexts #308

Merged

chrisrohr merged 1 commit into master from 307-validate-CleanupConfig-when-creating-ErrorContexts

Oct 26, 2023

Member

sleberknight commented Oct 26, 2023

Add CleanupConfig arg to checkCommonArguments and validate if not null
There is no need to call checkCommonArguments in buildWithJdbi3 in ErrorContextBuilder because the Jdbi3Context constructor performs validation itself (as does SimpleErrorContext)

Closes #307


          Validate CleanupConfig when building ErrorContexts

678fe20

* Add CleanupConfig arg to checkCommonArguments and validate if not null
* There is no need to call checkCommonArguments in buildWithJdbi3 in
  ErrorContextBuilder because the Jdbi3Context constructor performs
  validation itself (as does SimpleErrorContext)

Closes #307

sleberknight requested a review from chrisrohr

October 26, 2023 16:32

sleberknight assigned chrisrohr and sleberknight

sonarcloud bot commented Oct 26, 2023

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

100.0% Coverage
0.0% Duplication

chrisrohr approved these changes

View reviewed changes

chrisrohr merged commit 848ee9c into master

6 checks passed

chrisrohr deleted the 307-validate-CleanupConfig-when-creating-ErrorContexts branch

October 26, 2023 16:41

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet