Add support for headers to requests #207
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jekkel
requested changes
Sep 29, 2022
There was a problem hiding this comment.
Can you potentially write a small test scenario? This would involve:
- adjusting
./test/server/server.pyto be able to test whether headers are sent along - adjust
./test/resources/sidecar.yamlto configure a new sidecar instance or reconfigure an existing one to use request headers (also make sure it's configured with theREQ_URLfeature) - let a configmap entry of a configmap within
./test/resources/resources.yamlpoint to the locally deployed webserver - in the github test workflow add appropriate file downloads and verifications.
README.md
Outdated
| @@ -71,6 +71,7 @@ If the filename ends with `.url` suffix, the content will be processed as a URL | |||
| | `REQ_TIMEOUT` | How many seconds to wait for the server to send data before giving up for `.url` triggered requests or requests to `REQ_URI` (does not apply to k8s api requests) | false | `10` | float | | |||
| | `REQ_USERNAME` | Username to use for basic authentication for requests to `REQ_URL` and for `*.url` triggered requests | false | - | string | | |||
| | `REQ_PASSWORD` | Password to use for basic authentication for requests to `REQ_URL` and for `*.url` triggered requests | false | - | string | | |||
| | `REQ_HEADERS` | Headers for use for reqeusts to `REQ_URL` and for `*.url` triggered requets | `` | - | string | | |||
There was a problem hiding this comment.
there are two typos (reqeusts and requets) and please add an example value (for example {"x-apikey":"token"} if that's the expected format)
There was a problem hiding this comment.
Sorry for the delay on this and thanks for letting me know. I've fixed the spelling issues. Going to work on the tests now
|
Any active work on this? I came across it looking for this functionality. Happy to pick it up if OP is no longer maintaining it! |
github-actions
bot
added
the
stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To support other authentication methods as well as potential required headers from other services. Add support for passing a header object as stringified JSON