Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(uix/scrollview): Implement material design specifications for `MDS… #1629

Merged
merged 1 commit into from
Mar 1, 2024
Merged

(uix/scrollview): Implement material design specifications for `MDS… #1629

merged 1 commit into from
Mar 1, 2024

Conversation

T-Dynamos
Copy link
Collaborator

@T-Dynamos T-Dynamos commented Feb 27, 2024 •
edited
Loading

Closes #1602

@T-Dynamos T-Dynamos marked this pull request as draft February 27, 2024 14:02
HeaTTheatR
HeaTTheatR reviewed Feb 27, 2024
View reviewed changes
main.py Outdated Show resolved Hide resolved
@T-Dynamos T-Dynamos force-pushed the material_scroll branch 8 times, most recently from db2b74e to fa37d09 Compare February 29, 2024 11:23
@HeaTTheatR
Copy link
Member

In this implementation, the behavior needs to be slightly changed. In Android, it behaves somewhat differently, as far as I know. At the moment, the zoom effect is applied at the moment when the list has reached the end/beginning. In Android, the scale is also applied at the over_scroll event.

@HeaTTheatR
Copy link
Member

I can't help with this right now, because there are already a lot of changes in my local repository related to dynamic color, which does not work with the Python implementation. That is, I still have a lot of work to finish.

@T-Dynamos
Copy link
Collaborator Author

T-Dynamos commented Feb 29, 2024 •
edited
Loading

In this implementation, the behavior needs to be slightly changed. In Android, it behaves somewhat differently, as far as I know. At the moment, the zoom effect is applied at the moment when the list has reached the end/beginning. In Android, the scale is also applied at the over_scroll event.

You should try to force overscroll, it will zoom.

@HeaTTheatR
Copy link
Member

Cool! It's working now! Great job!

@T-Dynamos T-Dynamos changed the title WIP (uix/scrollview): Implement material design specifications for `MDS… (uix/scrollview): Implement material design specifications for `MDS… Feb 29, 2024
@T-Dynamos T-Dynamos marked this pull request as ready for review February 29, 2024 16:45
@HeaTTheatR HeaTTheatR merged commit 46be1e6 into master Mar 1, 2024
6 of 17 checks passed
@T-Dynamos T-Dynamos deleted the material_scroll branch March 1, 2024 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HeaTTheatR HeaTTheatR Awaiting requested review from HeaTTheatR

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement new "stretch and bounce back" scroll effect
2 participants
@T-Dynamos @HeaTTheatR