Support Java 20, remove Java 7 support #672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @cmacdonald !
https://github.com/cmacdonald/pyjnius/actions/runs/6230818141/job/16911405627 seems to fail for another reason, that you later addressed. Skipping the test on Windows x86 only seems much better than skipping it on both (we can even remove support for Windows x86 in future) What are your thoughts? |
|
Makes sense to me. Are you able to push to the PR to make the change. |
Thank you for speeding up the process! Seems to work! LGTM. Thank you! |
misl6
approved these changes
Sep 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Java 20 (released in March 2023) has removed support for compiling class files for JDK 7. This means Jnius doesn’t currently compile (nor run?) under Java 20.
Java SE 7 had End of Extended Support in July 2022. So we need no longer support Java 7 as a target.
Please consider this PR for 1.6.0 release cycle that
NB: I had to change the Java distribution in GHA to one that had Java 20 on most platforms.