Fix xcassets icon generation (correct image sizes) + stop overriding user defined assets once generated

[Novfensec]

Introduction

This pull-request is related to the below bug;

• Build Catalogue failed Images.xcassets #950

Changes

• Reworked the _buildimage function in kivy_ios.tools.external.xcassets to build correct image sizes.
• Made an adjustment to stop kivy-ios from overriding user defined assets like Images.xcassets.AppIcon.appiconset and Images.xcassets.LaunchImage.launchimage if they are already present.
• Test workflow run at https://github.com/Novfensec/Tic-Tac-Toe-Android/actions/runs/12210952062
• Hopefully passing all steps nicely.

With kivy_ios merging the below pull-requests along with this makes it usable along with buildozer:

• Upgrade itsdangerous recipe to 2.2.0 #946
• Fix ios deploy target #949

Testing

• python: 3.11
• Cython: 0.29.36
• Pillow: 8.2.0 with old recipe.
• itsdangerous: 2.2.0 with latest recipe by the pull-request Upgrade itsdangerous recipe to 2.2.0 #946.
• buildozer: 1.5.0

[Novfensec]

Hey @AndreMiras , I fixed the icon generation issues within the icon and _generate function. You can test build using branch patch-2 of https://github.com/Novfensec/kivy-ios/tree/patch-2 .

buildozer -v ios debug

[AndreMiras]

Thank you for spending time on that one 🙏
Would you mind editing the PR to not touch the formatting and address only the bug you mentioned in _buildimage()
Honestly I wish we had a formatter in the CI so it didn't have to be a recurring topic

[Novfensec]

Thank you for spending time on that one 🙏
Would you mind editing the PR to not touch the formatting and address only the bug you mentioned in _buildimage()
Honestly I wish we had a formatter in the CI so it didn't have to be a recurring topic

I used black for formatting. So, I'll just realign the list back to their original style. Please wait!!

[Novfensec]

@AndreMiras Reverted Dict formatting to original.

[misl6]

@Novfensec I see we still have some indentation that breaks the original style, can you please take a look?

[Novfensec]

Ahhh. Sorry for that I just overlooked, just a second!

[Novfensec]

@Novfensec I see we still have some indentation that breaks the original style, can you please take a look?

@misl6
Now is it okay?? All other changes are made to fix the overall process of generating images and icons nicely if there is no predefined Images.xcassets folder from the user side.

[Novfensec]

Hey, @misl6 @AndreMiras , I earlier thought of a mechanism which adds specific checks for each required icon file in the Appicon.appiconset and Launchimage.launchimage and generate it if its not already present.

These are the major steps :-

• Check for directories Appicon.appiconset and Launchimage.launchimage under Images.xcassets.
• Read the contents.json if present elsewise clear the directories and regenerate all icons and files with custom contents.json.
• If present then check for all defined files, attributes and sizes, generate if not present with the name or add any missed file entry and generate too.

This is a huge automation of the process, but this is likely to be very rarely used.
Beacause most of us won't specify these directories from ourselves.

For now it has only basic checks for directories not for specific files.

[misl6]

From your explanation I got what we're trying to achieve and how we can make the appropriate changes.

kivy-ios overriding the generated files is not necessarily a bug, actually that could be a wanted feature (or at least now is an undocumented feature that someone might be taking advantage of).

But, I also agree that in certain cases (like when used in buildozer automations) kivy-ios overriding user-defined assets might be unexpected.

Can we split the PRs in two parts?

• Fix correct image sizes
• Allow through a flag to not overwrite an already-existing asset (defaults to overwrite for backward compatibility)

Then, in buildozer, feel free to open a PR which adds an option to not overwrite an existing asset.

[Novfensec]

From your explanation I got what we're trying to achieve and how we can make the appropriate changes.

kivy-ios overriding the generated files is not necessarily a bug, actually that could be a wanted feature (or at least now is an undocumented feature that someone might be taking advantage of).

But, I also agree that in certain cases (like when used in buildozer automations) kivy-ios overriding user-defined assets might be unexpected.

Can we split the PRs in two parts?

• Fix correct image sizes
• Allow through a flag to not overwrite an already-existing asset (defaults to overwrite for backward compatibility)

Then, in buildozer, feel free to open a PR which adds an option to not overwrite an existing asset.

Yes, so should I unindent the code blocks or you'll undo those changes after merging, and make a new pull ??