update to matplotlib 3.7.2 #861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndreMiras
reviewed
Sep 11, 2023
There was a problem hiding this comment.
I remember I saw on the original PR the versions were a bit outdated, but I thought if it works, we can iterate on it later, which you did already, thanks.
My brain always melts when I read a diff of a .patch, basically a diff of a diff.
Anyway one of the build failed with:
2023-09-11T06:07:24.9146100Z Traceback (most recent call last):
2023-09-11T06:07:24.9195520Z File "/Users/runner/hostedtoolcache/Python/3.11.5/x64/bin/toolchain", line 33, in <module>
2023-09-11T06:07:24.9239650Z sys.exit(load_entry_point('kivy-ios==2023.8.24', 'console_scripts', 'toolchain')())
2023-09-11T06:07:24.9240130Z ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
2023-09-11T06:07:24.9294250Z File "/Library/Frameworks/Python.framework/Versions/3.11/lib/python3.11/site-packages/kivy_ios-2023.8.24-py3.11.egg/kivy_ios/toolchain.py", line 1664, in main
2023-09-11T06:07:24.9345590Z ToolchainCL()
2023-09-11T06:07:24.9379750Z File "/Library/Frameworks/Python.framework/Versions/3.11/lib/python3.11/site-packages/kivy_ios-2023.8.24-py3.11.egg/kivy_ios/toolchain.py", line 1401, in __init__
2023-09-11T06:07:24.9433820Z - Download 40427520 bytes
2023-09-11T06:07:24.9435210Z getattr(self, args.command)()
2023-09-11T06:07:24.9466200Z File "/Library/Frameworks/Python.framework/Versions/3.11/lib/python3.11/site-packages/kivy_ios-2023.8.24-py3.11.egg/kivy_ios/toolchain.py", line 1477, in build
2023-09-11T06:07:24.9494100Z build_recipes(args.recipe, ctx)
2023-09-11T06:07:24.9545700Z File "/Library/Frameworks/Python.framework/Versions/3.11/lib/python3.11/site-packages/kivy_ios-2023.8.24-py3.11.egg/kivy_ios/toolchain.py", line 1223, in build_recipes
2023-09-11T06:07:24.9587220Z recipe.execute()
2023-09-11T06:07:24.9615230Z File "/Library/Frameworks/Python.framework/Versions/3.11/lib/python3.11/site-packages/kivy_ios-2023.8.24-py3.11.egg/kivy_ios/toolchain.py", line 750, in execute
2023-09-11T06:07:24.9640770Z self.build_all()
2023-09-11T06:07:24.9660340Z File "/Library/Frameworks/Python.framework/Versions/3.11/lib/python3.11/site-packages/kivy_ios-2023.8.24-py3.11.egg/kivy_ios/toolchain.py", line 78, in _cache_execution
2023-09-11T06:07:24.9681920Z f(self, *args, **kwargs)
2023-09-11T06:07:24.9706090Z File "/Library/Frameworks/Python.framework/Versions/3.11/lib/python3.11/site-packages/kivy_ios-2023.8.24-py3.11.egg/kivy_ios/toolchain.py", line 850, in build_all
2023-09-11T06:07:24.9729790Z self.build(plat)
2023-09-11T06:07:24.9762260Z File "/Library/Frameworks/Python.framework/Versions/3.11/lib/python3.11/site-packages/kivy_ios-2023.8.24-py3.11.egg/kivy_ios/toolchain.py", line 78, in _cache_execution
2023-09-11T06:07:24.9795290Z f(self, *args, **kwargs)
2023-09-11T06:07:24.9820600Z File "/Library/Frameworks/Python.framework/Versions/3.11/lib/python3.11/site-packages/kivy_ios-2023.8.24-py3.11.egg/kivy_ios/toolchain.py", line 834, in build
2023-09-11T06:07:24.9847630Z self.prebuild_platform(plat)
2023-09-11T06:07:24.9877060Z File "/Library/Frameworks/Python.framework/Versions/3.11/lib/python3.11/site-packages/kivy_ios-2023.8.24-py3.11.egg/kivy_ios/recipes/matplotlib/__init__.py", line 74, in prebuild_platform
2023-09-11T06:07:24.9920730Z shutil.copyfile(
2023-09-11T06:07:24.9931140Z File "/Library/Frameworks/Python.framework/Versions/3.11/lib/python3.11/shutil.py", line 256, in copyfile
2023-09-11T06:07:24.9952550Z with open(src, 'rb') as fsrc:
2023-09-11T06:07:24.9976450Z ^^^^^^^^^^^^^^^
2023-09-11T06:07:24.9999980Z FileNotFoundError: [Errno 2] No such file or directory: '/Library/Frameworks/Python.framework/Versions/3.11/lib/python3.11/site-packages/kivy_ios-2023.8.24-py3.11.egg/kivy_ios/recipes/matplotlib/mplsetup.cfg'
2023-09-11T06:07:25.0024590Z Traceback (most recent call last):
2023-09-11T06:07:25.0045730Z File "/Users/runner/work/kivy-ios/kivy-ios/.ci/rebuild_updated_recipes.py", line 48, in <module>
2023-09-11T06:07:25.0058920Z main()
2023-09-11T06:07:25.0088790Z File "/Users/runner/work/kivy-ios/kivy-ios/.ci/rebuild_updated_recipes.py", line 40, in main
2023-09-11T06:07:25.0141220Z subprocess.run(
2023-09-11T06:07:25.0179670Z File "/Library/Frameworks/Python.framework/Versions/3.11/lib/python3.11/subprocess.py", line 571, in run
2023-09-11T06:07:25.0222340Z raise CalledProcessError(retcode, process.args,
2023-09-11T06:07:25.0248300Z subprocess.CalledProcessError: Command 'toolchain build matplotlib' returned non-zero exit status 1.
2023-09-11T06:07:25.0278170Z ##[error]Process completed with exit code 1.
|
My apologies. For most files, I find it better to switch from "Unified" to "Split" view when looking at the changes. I have added the missing entry to the manifest. |
AndreMiras
approved these changes
Sep 11, 2023
|
Thanks @AndreMiras ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update to matplotlib 3.7.2. I figure a newer version of numpy requires a newer version of matplotlib.