Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update for recent iOS platform changes #859

Merged
merged 1 commit into from
Sep 10, 2023
Merged

Conversation

tcaduser
Copy link
Contributor

Fix matplotlib build for new iOS changes. Asking for some feedback from @misl6

Creates:

dist/lib/iphoneos/libmatplotlib.a
dist/lib/iphonesimulator/libmatplotlib.a

when built on m1

@tcaduser
Copy link
Contributor Author

Looks like there is something missing in the ci regarding fp-model:

2023-09-10T17:11:58.8591440Z [DEBUG   ] clangclang: : error: error: unknown argument: '-fp-model'unknown argument: '-fp-model'
2023-09-10T17:11:58.8594220Z [DEBUG   ] 
2023-09-10T17:11:58.8595130Z [DEBUG   ] clang: error: unknown argument: '-fp-model'
2023-09-10T17:11:58.8596370Z [DEBUG   ] clangclang: : error: error: no such file or directory: 'strict'no such file or directory: 'strict'
2023-09-10T17:11:58.8597430Z [DEBUG   ] 
2023-09-10T17:11:58.8597950Z [DEBUG   ] clang: error: no such file or directory: 'strict'

@tcaduser
Copy link
Contributor Author

Please see Issue #860 for where things went wrong. @AndreMiras , could you please restart my build?

Copy link
Member

@AndreMiras AndreMiras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the quick follow up fixes.
Will merge if we don't get blocking comments in the next few hours

kivy_ios/recipes/matplotlib/setupext.py.patch Show resolved Hide resolved
@AndreMiras AndreMiras merged commit d5b8121 into kivy:master Sep 10, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants