Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the ability to pass arguments to as a string #726

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Added the ability to pass arguments to as a string #726

Changes from 5 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
8cc6e13
Added the ability to pass arguments to as a string
Neizvestnyj Jul 8, 2022
f5d7714
Added the ability to pass recipes arguments as a string
Neizvestnyj Jul 8, 2022
269fcfa
Added the ability to pass recipes arguments as a string
Neizvestnyj Jul 8, 2022
25166ac
Added the ability to transfer libraries in one line to the `toolchain…
Neizvestnyj Jul 13, 2022
46fba4e
Fix build error if pass arguments from console
Neizvestnyj Jul 13, 2022
e902608
Added `--r` for `toolchain build`
Neizvestnyj Jul 16, 2022
4691f18
Added `--r` argument for `toolchain build`
Neizvestnyj Jul 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions kivy_ios/toolchain.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1365,7 +1365,8 @@ def build(self):
if ctx.use_pbzip2:
logger.info("Using pbzip2 to decompress bzip2 data")

build_recipes(args.recipe, ctx)
recipe = ' '.join(args.recipe).replace(',', '').replace(' ', ' ').split()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Easy and effective, but looks quite hacky and I don't feel super-confident about merging it. (And should be handled on the argparser side instead)

How about an argument -r or --requirement which parses a requirements.txt file as pip does ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good, why not, I'll try to implement

build_recipes(recipe, ctx)

def recipes(self):
parser = argparse.ArgumentParser(
Expand Down Expand Up @@ -1511,7 +1512,8 @@ def pip3(self):
self.pip()

def pip(self):
_pip(sys.argv[2:])
args = ' '.join(sys.argv[2:]).replace(',', '').replace(' ', ' ').split()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

_pip is a "redirector" to an actual pip, so the arguments should be pip-compatible.

Why not using a requirements.txt file here?
toolchain pip install -r app-req.txt, would just work 😃

(Maybe we want to document it?)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hm, yes, it must be documented

_pip(args)

def launchimage(self):
from .tools.external import xcassets
Expand Down