Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds --add-custom-recipe to the update and create commands #643

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 33 additions & 4 deletions kivy_ios/toolchain.py
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
import argparse
import sys
from sys import stdout
from os.path import join, dirname, realpath, exists, isdir, basename
from os.path import join, dirname, realpath, exists, isdir, basename, split
from os import listdir, unlink, makedirs, environ, chdir, getcwd, walk
import sh
import zipfile
Expand Down Expand Up @@ -1188,7 +1188,7 @@ def _hostpython_pip(args):
shprint(pip_cmd, *args)


def update_pbxproj(filename, pbx_frameworks=None):
def update_pbxproj(filename, pbx_frameworks=None, custom_recipes=None, custom_recipes_paths=None):
# list all the compiled recipes
ctx = Context()
pbx_libraries = []
Expand All @@ -1197,7 +1197,17 @@ def update_pbxproj(filename, pbx_frameworks=None):
frameworks = []
libraries = []
sources = []

if custom_recipes and custom_recipes_paths:
recipes = custom_recipes
ctx.custom_recipes_paths = custom_recipes_paths
else:
recipes = []

for recipe in Recipe.list_recipes():
recipes.append(recipe)

for recipe in recipes:
key = "{}.build_all".format(recipe)
if key not in ctx.state:
continue
Expand Down Expand Up @@ -1413,12 +1423,22 @@ def status(self):
print("{:<12} - {}".format(
recipe, status))

def recipes_names_from_paths(self, paths):
recipes = []
for p in paths:
_, name = split(p)
recipes.append(name)

return recipes

def create(self):
parser = argparse.ArgumentParser(
description="Create a new xcode project")
parser.add_argument("name", help="Name of your project")
parser.add_argument("directory", help="Directory where your project lives")
parser.add_argument("--add-framework", action="append", help="Additional Frameworks to include with this project")
parser.add_argument("--add-custom-recipe", action="append", default=[],
help="Path to custom recipe")
args = parser.parse_args(sys.argv[2:])

from cookiecutter.main import cookiecutter
Expand Down Expand Up @@ -1446,7 +1466,11 @@ def create(self):
"{}-ios".format(args.name.lower()),
"{}.xcodeproj".format(args.name.lower()),
"project.pbxproj")
update_pbxproj(filename, pbx_frameworks=args.add_framework)

recipes = self.recipes_names_from_paths(args.add_custom_recipe)

update_pbxproj(filename, pbx_frameworks=args.add_framework,
custom_recipes=recipes, custom_recipes_paths=args.add_custom_recipe)
print("--")
print("Project directory : {}-ios".format(
args.name.lower()))
Expand All @@ -1458,6 +1482,8 @@ def update(self):
description="Update an existing xcode project")
parser.add_argument("filename", help="Path to your project or xcodeproj")
parser.add_argument("--add-framework", action="append", help="Additional Frameworks to include with this project")
parser.add_argument("--add-custom-recipe", action="append", default=[],
help="Path to custom recipe (the recipe must already have been built with the 'build' command)")
args = parser.parse_args(sys.argv[2:])

filename = self.find_xcodeproj(args.filename)
Expand All @@ -1466,7 +1492,10 @@ def update(self):
logger.error("{} not found".format(filename))
sys.exit(1)

update_pbxproj(filename, pbx_frameworks=args.add_framework)
recipes = self.recipes_names_from_paths(args.add_custom_recipe)

update_pbxproj(filename, pbx_frameworks=args.add_framework,
custom_recipes=recipes, custom_recipes_paths=args.add_custom_recipe)
print("--")
print("Project {} updated".format(filename))

Expand Down