Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the logger utilize rich to make the logs look nicer. #1709

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

matan-h
Copy link

@matan-h matan-h commented Sep 28, 2023

This would make the logs nicer by using the awesome rich library.
The current logs can be long and using rich will make them more readable and easier to find specific messages

@Julian-O
Copy link
Contributor

Some background:

  • Kivy, Buildozer and python-for-android each have their own custom logging solutions, that don't match!
  • I spent some effort a year ago to make Kivy logging follow the standard logging infrastructure.

I think you should break this into two steps.

The first is to change Buildozer's custom logger system to use the conventional python's logging class. I would like to see the Bulldozer logger inherit from Python logging.logger, rather than aggregating/shimming it.

After that, substituting in the new Rich handler should be trivial - I am not sure if it will be appreciated, as it won't match Kivy or Python-For-Android in appearance, but it should be trivial. (logging has a config system that might allow the user to choose.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants