dependencies: rm virtualenv, already using python3 -m venv
#1515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR removes the `virtualenv` dependency from `setup.py`, as it looks redundant. To be fair, I am not fully certain why setup.py was declaring `virtualenv` as needed, I think it's a historical remnant of python 2 days. The min required python version is atm 3.6: https://github.com/kivy/buildozer/blob/9503f5fd153f3f08e9160799fc04b23faf6aabeb/setup.py#L16 `venv` is part of the stdlib since python 3.3, and "is now recommended for creating virtual environments" since 3.5: https://docs.python.org/3/library/venv.html Note that `venv` is a subset of `virtualenv`, but buildozer AFAICT is only using that subset. Similar change in p4a: kivy/python-for-android#2152
SomberNight
added a commit
to SomberNight/electrum
that referenced
this pull request
Oct 14, 2022
virtualenv does not seem to be needed given python3-venv upstream ref: kivy/buildozer#1515
This was referenced Sep 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the
virtualenvdependency fromsetup.py, as it looks redundant.To be fair, I am not fully certain why setup.py was declaring
virtualenvas needed, I think it's a historical remnant of python 2 days.The min required python version is atm 3.6:
buildozer/setup.py
Line 16 in 9503f5f
venvis part of the stdlib since python 3.3, and "is now recommended for creating virtual environments" since 3.5: https://docs.python.org/3/library/venv.htmlNote that
venvis a subset ofvirtualenv, but buildozer AFAICT is only using that subset.Similar change in p4a:
kivy/python-for-android#2152
I've tested building a large android project with only
venvavailable and it worked.