Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1097 Add toml, pep517 and colorama to fix "android clean" command #1098

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Sirfanas
Copy link
Contributor

This is fixing issue #1097

Sirfanas and others added 2 commits May 11, 2020 15:44
jinja2 required by python-for-android to use "android clean"
@AndreMiras
Copy link
Member

Thanks for the report and PR. I'd like to see if I can reproduce it locally and if the changes fix it like we think.
Also if theses are really buildozer Python dependencies, then maybe it should be part of setup.py. I'd like to investigate a bit further before we merge

@Sirfanas
Copy link
Contributor Author

@AndreMiras I think it's not a buildozer requirements but a python-for-android requirements

@AndreMiras
Copy link
Member

Yes then this is probably were it should be handled. But buildozer relation with p4a is a bit tricky in that sense, still there's a way

@Sirfanas
Copy link
Contributor Author

@AndreMiras I think a good way to implement it would be to add everything in the p4a's requirements, cause it's used in it so it make sense
And to improve compilation time we can add them in the buildozer's Dockerfile, as it always need p4a
In this way when we manually install then every requirements would be installed, and Docker image's we'll be ready "out of the box", so it don't need any install to run command ("android clean" in this situation)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants