Implement 'unit' property #34
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementing x-axis units. This PR also solves issue (feature-request) #13.
Description:
The new 'unit' property determines the unit of x-axis values. The distance between the tick marks is divided by this number. Settings this to 0 will work as if it was set to 1, to avoid division by 0. Negative numbers are allowed.
For example, setting this and x_ticks_major to 60 will display x-axis ticks in minutes (by dividing major ticks by 60), assuming that data rate is once per second.
Use case:
At the moment, when data is fed into a graph 20 times per second, the best way to make it readable is to set x_ticks_major to 20, so that every vertical grid line represents one second. The x-axis labels are multiples of 20 though, which is confusing to end-users.
Settings the new 'unit' property to 20 in that case will divide the x-axis labels by 20, therefore making it more understandable to the end-user.