Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

let user set the side_panel height #9

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

yoelk
Copy link

@yoelk yoelk commented Apr 30, 2015

This feature is useful for apps that need to be run both on mobile
devices and on PCs. On the PC, the whole screen height might not be
needed, which leaves dead empty space in the current version.
With this new feature, the default height is the parent’s height, and
it can be explicitly set to be different by setting the
side_panel_height property to a custom value.

This feature is useful for apps that need to be run both on mobile
devices and on PCs. On the PC, the whole screen height might not be
needed, which leaves dead empty space in the current version.
With this new feature, the default height is the parent’s height, and
it can be explicitly set to be different by setting the
side_panel_height property to a custom value.
@KeyWeeUsr
Copy link
Member

I wonder if it's necessary after PR #8. This will set height, but will collide with the whole widget's area even after the 8th PR. You can accomplish this thing(and with correct collisions) when you place the drawer into something as a casual widget, so it'll be like this:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants