Add two additional logging options #22
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
First off `logger`, the new builtin logging framework. Secondly `hugin`, which builds on the former but also adds `domain` metadata based on the current `?MODULE`. Since both uses logger, this adds them at the same time.
maxno-kivra
requested review from
kbip and
zigge-zagge
and removed request for
kbip and
chsukivra
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First off
logger, the new builtin logging framework. Secondlyhugin,which builds on the former but also adds
domainmetadata based on thecurrent
?MODULE.Since both uses logger, this adds them at the same time.
This lays the groundwork for switching to logger, and I'll use this branch to test it in Beehive to begin with. But it should be safe to merge since the changes are behind option macros.