Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dialyzering for OTP 27 #50

Merged
merged 1 commit into from
Jun 20, 2024
Merged

Fix dialyzering for OTP 27 #50

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions rebar.config
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,3 +23,5 @@
deprecated_function_calls,deprecated_functions]}.

{erl_opts, [debug_info,warn_export_vars,warn_shadow_vars,warn_obsolete_guard]}.

{dialyzer, [{plt_extra_apps, [xmerl, erlsom]}]}.
2 changes: 1 addition & 1 deletion src/restc.erl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@
-type content_type() :: multi | json | xml | percent | png.
-type body() :: binary() |
jsx:json_term() |
erlsom:simple_form() |
term() | % check erlsom:simple_form/1,2
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know of a better way to do this.

  1. the erlsom:simple_form() type doesn't exist
  2. in our tests, for example, the return is a tuple, but without any proper "form"

My goal in adding the comment is to have the consumer look at the dependency, if they need it for that specific type.

multi_body().
-type multi_part() :: {Name::binary(), Value::binary()} |
{ file
Expand Down
Loading