Implement automatic request retry in the JS client #218
Conversation
| // Attach axios-retry to both axios instances | ||
| const raxConfig = { | ||
| // Retry 3 times on requests that return a response (500, etc) before giving up. | ||
| retry: 3, |
There was a problem hiding this comment.
We need to provide a limit here. Given the exponential backoff, at a certain point, retries should probably halt.
| httpMethodsToRetry: ['GET', 'HEAD', 'OPTIONS', 'DELETE', 'PUT', 'POST', 'PATCH'], | ||
| statusCodesToRetry: [[429, 429], [500, 599]], | ||
| onRetryAttempt: (err: AxiosError) => { | ||
|
|
There was a problem hiding this comment.
Unfortunately, this library just provides a global handler for the axios instance. I'm not sure if there's an easy way to notify the per-upload progress callback that their upload is currently retrying.
Is it an important feature that the progress callback actually communicate a retrying state, particularly given the fact that retries here will not continue indefinitely?
|
This implements automatic request retry using a library, which is a lot less code for us to maintain. In some ways, this has slightly fewer features, but the behavior here is a lot closer to the automatic retry logic that I'd expect to implement for most backends. Retrying a limited number of times automatically, then giving up, is a more conservative behavior for now. |
No description provided.