Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend signature expiration time to 7 days #208

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

zachmullen
Copy link
Contributor

This reduces the probability of users timing out on uploads, and from a theoretical security standpoint, isn't materially worse than 1 day.

Note that 7 days is the maximum amount supported by access key signing in S3.

This reduces the probability of users timing out on uploads, and from a theoretical security standpoint, isn't materially worse than 1 day.

Note that 7 days is the maximum amount supported by access key signing.
@zachmullen
Copy link
Contributor Author

zachmullen commented Mar 4, 2021

Yes, theoretically, a big enough file could still take over 7 days on a slow enough connection. But adding refresh signature logic is a lot more complicated than this change -- not to mention, the inflection point at which it's faster to ship a hard drive than transfer over the network is likely somewhere between 1 and 7 days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Needs review
Development

Successfully merging this pull request may close these issues.

1 participant