Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update generic_client.go, resolve the issue where the kitexcall -f /path/to/file.json command is not working. #16

Merged
merged 3 commits into from
Nov 8, 2024

Conversation

xuanskyer
Copy link
Contributor

Resolve the issue where the kitexcall -f /path/to/file.json command is not working.

What type of PR is this?

fix: A bug fix

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo

(Optional) Translate the PR title into Chinese.

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en:
zh(optional):

(Optional) Which issue(s) this PR fixes:

(optional) The PR that updates user documentation:

Resolve the issue where the kitexcall -f /path/to/file.json command is not working.
@CLAassistant
Copy link

CLAassistant commented Nov 6, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: xuanskyer

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@xuanskyer
Copy link
Contributor Author

xuanskyer commented Nov 6, 2024

@Zzhiter @HeyJavaBean pls help review this PR, tks!

@Zzhiter
Copy link
Collaborator

Zzhiter commented Nov 7, 2024

@xuanskyer Could you please rebase mater? CI fails to run now and needs to be updated.

@GuangmingLuo
Copy link
Member

Please rebase main

@xuanskyer
Copy link
Contributor Author

Please rebase main

done

@xuanskyer
Copy link
Contributor Author

@xuanskyer Could you please rebase mater? CI fails to run now and needs to be updated.

done

@Zzhiter Zzhiter merged commit 961589b into kitex-contrib:main Nov 8, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants