Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat:add kitexcall version #11

Merged
merged 8 commits into from
Jun 18, 2024
Merged

feat:add kitexcall version #11

merged 8 commits into from
Jun 18, 2024

Conversation

SHENCaesar
Copy link
Contributor

@SHENCaesar SHENCaesar commented Jun 7, 2024

What type of PR is this?

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo

(Optional) Translate the PR title into Chinese.

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en:
zh(optional):

(Optional) Which issue(s) this PR fixes:

(optional) The PR that updates user documentation:

Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: SHENCaesar

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

pkg/config/config.go Outdated Show resolved Hide resolved
pkg/argparse/args.go Outdated Show resolved Hide resolved
pkg/argparse/args.go Outdated Show resolved Hide resolved
pkg/config/config.go Outdated Show resolved Hide resolved
pkg/versions/version.go Outdated Show resolved Hide resolved
pkg/argparse/args.go Outdated Show resolved Hide resolved
@CLAassistant
Copy link

CLAassistant commented Jun 9, 2024

CLA assistant check
All committers have signed the CLA.

@Zzhiter
Copy link
Collaborator

Zzhiter commented Jun 9, 2024

@SHENCaesar lint failed: https://github.com/kitex-contrib/kitexcall/actions/runs/9436644358/job/25991876137?pr=11

@SHENCaesar
Copy link
Contributor Author

@SHENCaesar lint failed: https://github.com/kitex-contrib/kitexcall/actions/runs/9436644358/job/25991876137?pr=11

The lint failed is caused by misalignment of the format, has been corrected, thanks for correcting @Zzhiter

@Zzhiter
Copy link
Collaborator

Zzhiter commented Jun 11, 2024

@SHENCaesar lint failed: https://github.com/kitex-contrib/kitexcall/actions/runs/9436644358/job/25991876137?pr=11

The lint failed is caused by misalignment of the format, has been corrected, thanks for correcting @Zzhiter

ok, looks good to me.

@Zzhiter Zzhiter merged commit e6b232e into kitex-contrib:main Jun 18, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants