Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more targets #38

Merged
merged 2 commits into from
Jan 12, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .goreleaser.yml
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,8 @@ nfpms:

kos:
- base_image: alpine
repository: ghcr.io/kishaningithub/tf-import-gen
repositories:
- ghcr.io/kishaningithub/tf-import-gen
platforms:
- linux/amd64
- linux/arm64
Expand Down
5 changes: 5 additions & 0 deletions pkg/convertor.go
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ func computeTerraformImportForResource(resource parser.TerraformResource) Terraf
"google_compute_instance_template",
"google_iap_tunnel_instance_iam_binding",
"local_file",
"tailscale_tailnet_key",
}
if slices.Contains(resourcesWhichDoNotSupportImport, resource.Type) {
return TerraformImport{
Expand Down Expand Up @@ -139,10 +140,14 @@ func computeResourceID(resource parser.TerraformResource) string {
return fmt.Sprintf("%s %s", v("secret_id"), v("role"))
case "google_secret_manager_secret_iam_member":
return fmt.Sprintf("%s %s %s", v("secret_id"), v("role"), v("member"))
case "google_secret_manager_secret":
return v("name")
case "google_storage_bucket_iam_member":
return fmt.Sprintf("%s %s %s", v("bucket"), v("role"), v("member"))
case "google_storage_bucket_iam_binding":
return fmt.Sprintf("%s %s", v("bucket"), v("role"))
case "google_tags_tag_key_iam_member":
return fmt.Sprintf("%s %s %s", v("tag_key"), v("role"), v("member"))
case "google_compute_subnetwork_iam_binding":
return fmt.Sprintf("%s %s", v("subnetwork"), v("role"))
case "google_pubsub_topic_iam_binding":
Expand Down
35 changes: 35 additions & 0 deletions pkg/convertor_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -498,6 +498,24 @@ func Test_ComputeTerraformImportForResource(t *testing.T) {
SupportsImport: true,
},
},
{
name: "For google_tags_tag_key_iam_member.tailscale_services_tag_user",
terraformResource: parser.TerraformResource{
Address: "google_tags_tag_key_iam_member.tailscale_services_tag_user",
Type: "google_tags_tag_key_iam_member",
AttributeValues: map[string]any{
"id": "tagKeys/123456789012345/projects/project/roles/customTailscaleRole/serviceAccount:[email protected]",
"member": "serviceAccount:[email protected]",
"role": "projects/project/roles/customTailscaleRole",
"tag_key": "tagKeys/123456789012345",
},
},
expected: TerraformImport{
ResourceAddress: "google_tags_tag_key_iam_member.tailscale_services_tag_user",
ResourceID: "tagKeys/123456789012345 projects/project/roles/customTailscaleRole serviceAccount:[email protected]",
SupportsImport: true,
},
},
{
name: "For google_privateca_ca_pool_iam_member.pool",
terraformResource: parser.TerraformResource{
Expand Down Expand Up @@ -777,6 +795,23 @@ func Test_ComputeTerraformImportForResource(t *testing.T) {
SupportsImport: true,
},
},
{
name: "For google_secret_manager_secret.gcp_connector_secret",
terraformResource: parser.TerraformResource{
Address: "google_secret_manager_secret.gcp_connector_secret",
Type: "google_secret_manager_secret",
AttributeValues: map[string]any{
"id": "projects/project/secrets/a-secret-key",
"name": "projects/1234567890/secrets/a-secret-key",
"project": "us-shared-prod",
},
},
expected: TerraformImport{
ResourceAddress: "google_secret_manager_secret.gcp_connector_secret",
ResourceID: "projects/1234567890/secrets/a-secret-key",
SupportsImport: true,
},
},
{
name: "For google_storage_bucket_iam_member",
terraformResource: parser.TerraformResource{
Expand Down
Loading