Skip to content

Commit

Permalink
Add moar targets
Browse files Browse the repository at this point in the history
  • Loading branch information
fiskhest committed Jan 10, 2025
1 parent 836cc2a commit 6257a87
Show file tree
Hide file tree
Showing 2 changed files with 40 additions and 0 deletions.
5 changes: 5 additions & 0 deletions pkg/convertor.go
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ func computeTerraformImportForResource(resource parser.TerraformResource) Terraf
"google_compute_instance_template",
"google_iap_tunnel_instance_iam_binding",
"local_file",
"tailscale_tailnet_key",
}
if slices.Contains(resourcesWhichDoNotSupportImport, resource.Type) {
return TerraformImport{
Expand Down Expand Up @@ -139,10 +140,14 @@ func computeResourceID(resource parser.TerraformResource) string {
return fmt.Sprintf("%s %s", v("secret_id"), v("role"))
case "google_secret_manager_secret_iam_member":
return fmt.Sprintf("%s %s %s", v("secret_id"), v("role"), v("member"))
case "google_secret_manager_secret":
return v("name")
case "google_storage_bucket_iam_member":
return fmt.Sprintf("%s %s %s", v("bucket"), v("role"), v("member"))
case "google_storage_bucket_iam_binding":
return fmt.Sprintf("%s %s", v("bucket"), v("role"))
case "google_tags_tag_key_iam_member":
return fmt.Sprintf("%s %s %s", v("tag_key"), v("role"), v("member"))
case "google_compute_subnetwork_iam_binding":
return fmt.Sprintf("%s %s", v("subnetwork"), v("role"))
case "google_pubsub_topic_iam_binding":
Expand Down
35 changes: 35 additions & 0 deletions pkg/convertor_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -498,6 +498,24 @@ func Test_ComputeTerraformImportForResource(t *testing.T) {
SupportsImport: true,
},
},
{
name: "For google_tags_tag_key_iam_member.tailscale_services_tag_user",
terraformResource: parser.TerraformResource{
Address: "google_tags_tag_key_iam_member.tailscale_services_tag_user",
Type: "google_tags_tag_key_iam_member",
AttributeValues: map[string]any{
"id": "tagKeys/123456789012345/projects/project/roles/customTailscaleRole/serviceAccount:[email protected]",
"member": "serviceAccount:[email protected]",
"role": "projects/project/roles/customTailscaleRole",
"tag_key": "tagKeys/123456789012345",
},
},
expected: TerraformImport{
ResourceAddress: "google_tags_tag_key_iam_member.tailscale_services_tag_user",
ResourceID: "tagKeys/123456789012345 projects/project/roles/customTailscaleRole serviceAccount:[email protected]",
SupportsImport: true,
},
},
{
name: "For google_privateca_ca_pool_iam_member.pool",
terraformResource: parser.TerraformResource{
Expand Down Expand Up @@ -777,6 +795,23 @@ func Test_ComputeTerraformImportForResource(t *testing.T) {
SupportsImport: true,
},
},
{
name: "For google_secret_manager_secret.gcp_connector_secret",
terraformResource: parser.TerraformResource{
Address: "google_secret_manager_secret.gcp_connector_secret",
Type: "google_secret_manager_secret",
AttributeValues: map[string]any{
"id": "projects/project/secrets/a-secret-key",
"name": "projects/1234567890/secrets/a-secret-key",
"project": "us-shared-prod",
},
},
expected: TerraformImport{
ResourceAddress: "google_secret_manager_secret.gcp_connector_secret",
ResourceID: "projects/1234567890/secrets/a-secret-key",
SupportsImport: true,
},
},
{
name: "For google_storage_bucket_iam_member",
terraformResource: parser.TerraformResource{
Expand Down

0 comments on commit 6257a87

Please sign in to comment.