refactor: conditional types for KeyboardAvoidingView
#711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kirillzyusko
added
the
KeyboardAvoidingView 🧪
📊 Package size report
|
This was referenced Dec 16, 2024
kirillzyusko
added a commit
that referenced
this pull request
Dec 16, 2024
## 📜 Description Remove `contentContainerStyle` for `KeyboardAvoidingView` in documentation as it's not needed and after #711 it trigerrs TS errors. ## 💡 Motivation and Context Conditional types were added intentionally to spot issues like this. Glad to see it works 😅 Closes #732 ## 📢 Changelog <!-- High level overview of important changes --> <!-- For example: fixed status bar manipulation; added new types declarations; --> <!-- If your changes don't affect one of platform/language below - then remove this platform/language --> ### Docs - remove `contentContainerStyle` for `KeyboardAvoidingView`. ## 🤔 How Has This Been Tested? Tested on localhost:3000 ## 📝 Checklist - [x] CI successfully passed - [x] I added new mocks and corresponding unit-tests if library API was changed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
contentContainerStylecan be used only whenbehavior="position".💡 Motivation and Context
To eep people aware about that additionally I decided to specify conditional TS types. Now people will get a warning if they specify this property and don't specify behavior as
position.📢 Changelog
JS
KeyboardAvoidingView;🤔 How Has This Been Tested?
Tested in example project.
📸 Screenshots (if appropriate):
Forbidden
Allowed
📝 Checklist