fix: missing update in useWindowDimensions
#701
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Fixed broken layout of
KeyboardAvoidingView
whenKeyboardAvoidingView
mounted on app start.💡 Motivation and Context
The problem was in fact, that event arrived after
useState
initalization, but before adding a new listener. So we had a missing event and as a resultscreenHeight
was0
.To fix this I applied a very similar logic to what
useWindowDimensions
hook does fromreact-native
. WhenuseEffect
callback gets executed we update state withinitialDimensions
. The value ofinitialDimensions
will be always actual, because it's located outside of the hook.📢 Changelog
JS
useEffect
withinitialDimensions
;🤔 How Has This Been Tested?
Tested manually on
Medium_Phone_API_35
.📝 Checklist