Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: new KeyboardController.isVisible() method #694

Merged
merged 1 commit into from
Nov 18, 2024
Merged

feat: new KeyboardController.isVisible() method #694

merged 1 commit into from
Nov 18, 2024

Conversation

kirillzyusko
Copy link
Owner

@kirillzyusko kirillzyusko commented Nov 15, 2024 •
edited
Loading

📜 Description

Added KeyboardController.isVisible() method.

💡 Motivation and Context

I decided to match Keyboard API from react-native more closely, and I thought that isVisible() method can be useful in many places.

So in this PR I'm adding isVisible method.

📢 Changelog

Docs

  • added API spec for new method.

JS

  • added isVisible method to KeyboardController API.

🤔 How Has This Been Tested?

Tested manually.

📝 Checklist

  • CI successfully passed
  • I added new mocks and corresponding unit-tests if library API was changed

@kirillzyusko kirillzyusko added documentation Improvements or additions to documentation enhancement New feature or request 🚨 requires API changes 🚨 Changes that requires changes in library API labels Nov 15, 2024
@kirillzyusko kirillzyusko self-assigned this Nov 15, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 15, 2024 •
edited
Loading

📊 Package size report

Current size Target Size Difference
161032 bytes 160875 bytes 157 bytes 📈

Base automatically changed from feat/async-dismiss to main November 18, 2024 13:20
@kirillzyusko kirillzyusko marked this pull request as ready for review November 18, 2024 13:22
@github-actions GitHub Actions
Copy link
Contributor

PR Preview Action v1.4.8
🚀 Deployed preview to https://kirillzyusko.github.io/react-native-keyboard-controller/pr-preview/pr-694/
on branch gh-pages at 2024-11-18 13:23 UTC

@argos-ci Argos CI
Copy link

argos-ci bot commented Nov 18, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) ✅ No changes detected - Nov 18, 2024, 1:24 PM

@kirillzyusko kirillzyusko merged commit 972787d into main Nov 18, 2024
17 checks passed
@kirillzyusko kirillzyusko deleted the feat/is-visible branch November 18, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@kirillzyusko kirillzyusko

Labels
documentation Improvements or additions to documentation enhancement New feature or request 🚨 requires API changes 🚨 Changes that requires changes in library API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kirillzyusko