You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make dismiss method async to get rid off boilerplate/utilities functions in main project.
💡 Motivation and Context
Originally this idea was suggested by @terrysahaidak. Before many projects had its own implementation of this method. But @terrysahaidak suggested and I agreed that it would be better to keep this method directly inside the library.
📢 Changelog
Docs
include methods signature in methods description;
JS
changed mock implementation;
make dismiss method async;
create module file;
set global listeners for KeyboardEvents inside module file;
🤔 How Has This Been Tested?
Tested on CI.
📝 Checklist
CI successfully passed
I added new mocks and corresponding unit-tests if library API was changed
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
kirillzyusko
added
documentation
📜 Description
Make
dismissmethod async to get rid off boilerplate/utilities functions in main project.💡 Motivation and Context
Originally this idea was suggested by @terrysahaidak. Before many projects had its own implementation of this method. But @terrysahaidak suggested and I agreed that it would be better to keep this method directly inside the library.
📢 Changelog
Docs
JS
dismissmethod async;modulefile;KeyboardEventsinsidemodulefile;🤔 How Has This Been Tested?
Tested on CI.
📝 Checklist