fix: resolve react native dir in monorepo in android build #692
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
I updated
resolveReactNativeDirectory
inandroid/react-native-helpers.gradle
to handle custom directory structures in a more generic way.As in the previous version, I followed how software-mansion resolved this problem.
💡 Motivation and Context
I am working on a monorepo that's follow this structure
The previous monorepo workaround was limited to two hardcoded paths.
My monorepo is build with Turborepo. Referring to their docs:
We can't be sure that
react-native
andreact-native-keyboard-controller
folders are in the samenode_modules
folder.📢 Changelog
fixed android build in monorepo
Android
resolve node modules react native directory using node resolver instead of hardcoded paths
🤔 How Has This Been Tested?
I tested android build in a monorepo created with turbo repo, in standalone react native app repo and in the example app.
📸 Screenshots (if appropriate):
📝 Checklist