Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e: consistent tests across platforms #690

Merged
merged 7 commits into from
Nov 15, 2024
Merged

Conversation

kirillzyusko
Copy link
Owner

@kirillzyusko kirillzyusko commented Nov 15, 2024

📜 Description

Made e2e tests better 🙂

💡 Motivation and Context

The main motivation to do that was to have device.tap() method - it would allow us to test switch to emoji keyboard. I added this, but then realized, that flag SOFT_CHECK doesn't satisfy for previous goals, so I decided to create devicePreferences mechanism.

Then I tried to enable OverKeyboardView tests and suddenly they started to work 😲

Last piece was updating KeyboardToolbar tests 🙂

📢 Changelog

E2E

  • enable emoji keyboard tests on iOS;
  • enable OverKeyboardView tests on iOS;
  • update detox to latest version;
  • fix KeyboardToolbar incompatibility with new Detox version;
  • add getDevicePreference method;
  • generate missing assets;

🤔 How Has This Been Tested?

Tested on CI.

📝 Checklist

  • CI successfully passed
  • I added new mocks and corresponding unit-tests if library API was changed

@kirillzyusko kirillzyusko added documentation Improvements or additions to documentation e2e Anything about E2E tests labels Nov 15, 2024
@kirillzyusko kirillzyusko self-assigned this Nov 15, 2024
Copy link
Contributor

github-actions bot commented Nov 15, 2024

📊 Package size report

Current size Target Size Difference
159566 bytes 159566 bytes 0 bytes 📉

Copy link
Contributor

github-actions bot commented Nov 15, 2024

PR Preview Action v1.4.8
Preview removed because the pull request was closed.
2024-11-15 12:47 UTC

Copy link

argos-ci bot commented Nov 15, 2024

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) 👍 Changes approved 1 changed Dec 31, 2024, 11:12 PM

@kirillzyusko kirillzyusko added the deps update Upgrade dependencies of the project label Nov 15, 2024
@kirillzyusko kirillzyusko marked this pull request as ready for review November 15, 2024 12:43
@kirillzyusko kirillzyusko merged commit 7d02596 into main Nov 15, 2024
18 checks passed
@kirillzyusko kirillzyusko deleted the e2e/technical-debt branch November 15, 2024 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deps update Upgrade dependencies of the project documentation Improvements or additions to documentation e2e Anything about E2E tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant