-
-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
e2e: consistent tests across platforms #690
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kirillzyusko
added
documentation
Improvements or additions to documentation
e2e
Anything about E2E tests
labels
Nov 15, 2024
📊 Package size report
|
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
kirillzyusko
force-pushed
the
e2e/technical-debt
branch
from
November 15, 2024 11:31
576cc90
to
0149fd8
Compare
2 tasks
This reverts commit 0149fd8.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
deps update
Upgrade dependencies of the project
documentation
Improvements or additions to documentation
e2e
Anything about E2E tests
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Made e2e tests better 🙂
💡 Motivation and Context
The main motivation to do that was to have
device.tap()
method - it would allow us to test switch to emoji keyboard. I added this, but then realized, that flagSOFT_CHECK
doesn't satisfy for previous goals, so I decided to createdevicePreferences
mechanism.Then I tried to enable
OverKeyboardView
tests and suddenly they started to work 😲Last piece was updating
KeyboardToolbar
tests 🙂📢 Changelog
E2E
OverKeyboardView
tests on iOS;KeyboardToolbar
incompatibility with new Detox version;getDevicePreference
method;🤔 How Has This Been Tested?
Tested on CI.
📝 Checklist