feat(android): add JSPointerDispatcherCompat for RN < 0.72 #681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thank you @gronxb for a contribution 🙌 Let me approve and run e2e tests to see if they pass or not 👀 |
📊 Package size report
|
I think running e2e tests should be enough. I'm testing there that |
|
@kirillzyusko Since ktlint was failing, I executed ktlint. |
|
@gronxb |
...d/src/main/java/com/reactnativekeyboardcontroller/views/overlay/JSPointerDispatcherCompat.kt
Outdated
Show resolved
Hide resolved
...d/src/main/java/com/reactnativekeyboardcontroller/views/overlay/JSPointerDispatcherCompat.kt
Outdated
Show resolved
Hide resolved
...d/src/main/java/com/reactnativekeyboardcontroller/views/overlay/JSPointerDispatcherCompat.kt
Show resolved
Hide resolved
...d/src/main/java/com/reactnativekeyboardcontroller/views/overlay/JSPointerDispatcherCompat.kt
Show resolved
Hide resolved
2 tasks
kirillzyusko
added a commit
that referenced
this pull request
Nov 13, 2024
## 📜 Description In #681 we started to use reflection for detection the amount of params. But reflection is a slow mechanism, so in this PR I'm optimizing lookup stage by calculating a correct method only one time. ## 💡 Motivation and Context Lookup can be up to 10-100 times slower comparing to the direct function call. If we call this method too frequently, we can encounter a bottleneck. To make this code faster I decided to cache the method (thus we do a lookup only one time). This approach should almost neglect performance impact for a lookup stage. The call stage (method invocation) still will add an overhead, but it should have a small impact. ## 📢 Changelog ### Android - cache method (make it lazy calculated); - move constants to companion object. ## 🤔 How Has This Been Tested? Tested on CI. ## 📝 Checklist - [x] CI successfully passed - [x] I added new mocks and corresponding unit-tests if library API was changed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
To add a compatibility layer for
JSPointerDispatcher, ensure that the method functions correctly regardless of whether it is called with two or three parameters.💡 Motivation and Context
Related:
facebook/react-native@1e53f88#diff-e874545c1f508ac02d63d67356fe0519f6c0dd5f380afeb900cf1de4fce6835aL202-R203
With the change, the number of parameters has increased from two to three. Since React Native 0.71.14 only uses two parameters, this causes a build error on Android.
📢 Changelog
Android
JSPointerDispatcherCompatclass🤔 How Has This Been Tested?
📸 Screenshots (if appropriate):
📝 Checklist