chore: react-native 0.76 #656
Conversation
📊 Package size report
|
| "@gorhom/bottom-sheet": "^4.6.4", | ||
| "@react-native-community/blur": "^4.4.0", | ||
| "@gorhom/bottom-sheet": "4.6.4", | ||
| "@react-native-community/blur": "^4.4.1", |
There was a problem hiding this comment.
Not sure, but somewhere you removed the ^ from the library version, would it be better to follow this approach for the whole file in the future?
There was a problem hiding this comment.
v5 broke e2e tests 🙂
FabricExample/patches/react-native-safe-area-context+4.11.1.patch
Outdated
Show resolved
Hide resolved
| @@ -75,7 +75,7 @@ export default function AwareScrollView({ navigation }: Props) { | |||
| {new Array(10).fill(0).map((_, i) => ( | |||
| <TextInput | |||
| key={i} | |||
| contextMenuHidden={i === 4} | |||
| contextMenuHidden={i === 4 && Platform.OS === "ios"} | |||
There was a problem hiding this comment.
previously it was applied for both platforms, why did you change it?
There was a problem hiding this comment.
I had to use the hack with hidden context menu on iOS, because for some reasons on CI I'm getting different items comparing to my local simulator (I'm also getting Share and other items on CI)
On Android there is no such problem, so I decided to be a little bit more specific
Starting from 0.76 they disabled text selection if context menu is hidden, so you literally select text and after 16ms cursor gets moved to the end of text - and I don't handle the scenario where cursor is located a the end and i do not scroll
Because of that e2e test is broken - for now I just disabled context menu on iOS (because this was the original platform with the issue)
I hope in future versions of keyboard-controller I can re-work KeyboardAwareScrollView so that it will handle all cases (even when cursor is in the end).
| @@ -34,4 +34,4 @@ newArchEnabled=false | |||
|
|
|||
| # Use this property to enable or disable the Hermes JS engine. | |||
| # If set to false, you will be using JSC instead. | |||
| hermesEnabled=false | |||
| hermesEnabled=true | |||
There was a problem hiding this comment.
hm, do you want to enable new arch in paper example?
There was a problem hiding this comment.
I think I had to enable Hermes to prevent crash on start (the stack trace was coming from reanimated)
| @@ -75,7 +75,7 @@ export default function AwareScrollView({ navigation }: Props) { | |||
| {new Array(10).fill(0).map((_, i) => ( | |||
| <TextInput | |||
| key={i} | |||
| contextMenuHidden={i === 4} | |||
| contextMenuHidden={i === 4 && Platform.OS === "ios"} | |||
There was a problem hiding this comment.
previously it was applied for both platforms, why did you change it?
There was a problem hiding this comment.
I had to use the hack with hidden context menu on iOS, because for some reasons on CI I'm getting different items comparing to my local simulator (I'm also getting Share and other items on CI)
On Android there is no such problem, so I decided to be a little bit more specific
Starting from 0.76 they disabled text selection if context menu is hidden, so you literally select text and after 16ms cursor gets moved to the end of text - and I don't handle the scenario where cursor is located a the end and i do not scroll
Because of that e2e test is broken - for now I just disabled context menu on iOS (because this was the original platform with the issue)
I hope in future versions of keyboard-controller I can re-work KeyboardAwareScrollView so that it will handle all cases (even when cursor is in the end).
kirillzyusko
force-pushed
the
chore/react-native-0.76.0
branch
from
191e69b to
245aae6
Compare
|
Opened an issue in RN: facebook/react-native#47307 Currently merge is blocked by this issue |
This reverts commit 40d37c3.
…tly hide the selection. Let's try to enable it only for iOS because on top of my head it was only iOS specific problem (we had different options comparing locally vs CI)
kirillzyusko
force-pushed
the
chore/react-native-0.76.0
branch
from
245aae6 to
21a9a8f
Compare
📜 Description
Update
react-nativeto0.76.2.💡 Motivation and Context
To stay up-do-date with ecosystem.
Key points:
contextMenuHiddenonly on iOS (see fix TextInput 'contextMenuHidden' prop facebook/react-native#45014 - now if we select entire text the cursor gets moved to the end and we don't handle the event when cursor is located in the end).📢 Changelog
JS
Android
🤔 How Has This Been Tested?
tested on:
📝 Checklist