fix: missing onScroll
event in KeyboardAwareScrollView
#408
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Fixed firing of
onScroll
inKeyboardAwareScrollView
💡 Motivation and Context
Initially it was fixed in #339 and I'm sure it was working 😅
However it looks like in current setup (RN 0.73, REA 3.8.0) such way is not working and
onScroll
property still gets ignored 😔So in this PR I followed a different path: initially I wanted to fire this handler via
runOnJS
, but we can not follow a full signature of the method, since REA has onlynativeEvent
property (and indeed in this case some properties would be simply missing).The different path was to update a shared value from JS thread and call a callback as usually - it fixes a problem in old code and in a new, so for now this approach looks decent 👍
Let's see how it works in a wild life 👀
Also in this PR I'm changing content of
tea.yaml
- it should be done in separate PR, but I don't want to open another PR just to fix quotes, so decided to merge everything in a single one 🙈Closes #337
📢 Changelog
JS
onScroll
in callback;FS (file system)
'
fortea.yaml
;🤔 How Has This Been Tested?
Tested manually on iPhone 15 Pro.
📸 Screenshots (if appropriate):
📝 Checklist