Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: added mock for useKeyboardContext #361

Merged
merged 1 commit into from
Feb 18, 2024

Conversation

kirillzyusko
Copy link
Owner

@kirillzyusko kirillzyusko commented Feb 18, 2024

📜 Description

Added mock for useKeyboardContext + AndroidSoftInputModes.

💡 Motivation and Context

useKeyboardContext and AndroidSoftInputModes is a part of official API of this library. However they are not exported from the library (so if you use them in unit-test -> this test will not pass and you will have to mock it manually).

So in this PR I'm adding them to mock and also adding a new unit test which assures that new mocks are actually present.

📢 Changelog

JS

  • added mock for useKeyboardContext;
  • added mock for AndroidSoftInputModes.

🤔 How Has This Been Tested?

Tested manually via newly added test.

📸 Screenshots (if appropriate):

image

📝 Checklist

  • CI successfully passed
  • I added new mocks and corresponding unit-tests if library API was changed

@kirillzyusko kirillzyusko added the 🐛 bug Something isn't working label Feb 18, 2024
@kirillzyusko kirillzyusko self-assigned this Feb 18, 2024
Copy link
Contributor

📊 Package size report

Current size Target Size Difference
109973 bytes 109837 bytes 136 bytes 📈

@kirillzyusko kirillzyusko marked this pull request as ready for review February 18, 2024 20:17
@kirillzyusko kirillzyusko merged commit 620f379 into main Feb 18, 2024
10 checks passed
@kirillzyusko kirillzyusko deleted the fix/use-keyboard-context-mock branch February 18, 2024 20:33
@kirillzyusko kirillzyusko added the tests You added or changed unit tests label Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working tests You added or changed unit tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant