Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove replicas #358

Merged
merged 1 commit into from
Feb 13, 2024
Merged

refactor: remove replicas #358

merged 1 commit into from
Feb 13, 2024

Conversation

kirillzyusko
Copy link
Owner

@kirillzyusko kirillzyusko commented Feb 12, 2024

📜 Description

Removed replicas from the package.

💡 Motivation and Context

Initially when I started to work on this package I thought to add replicas for iOS or Android if I can not derive values from a native code. Turned out I can actually derive them, so replicas are kind of not useful anymore.

These methods were not documented anywhere, but I see that people are constantly trying to find these methods in documentation:

image

Since these methods were never a part of official API of this library - I'm removing them 😎

Also this change can be considered as optimization, because I'm removing code and thus reduce size of the package.

📢 Changelog

JS

  • removed replicas

🤔 How Has This Been Tested?

Tested manually on iPhone 15 Pro and Pixel 2.

📝 Checklist

  • CI successfully passed
  • I added new mocks and corresponding unit-tests if library API was changed

Copy link
Contributor

📊 Package size report

Current size Target Size Difference
109837 bytes 116043 bytes -6206 bytes 📉

@kirillzyusko kirillzyusko self-assigned this Feb 13, 2024
@kirillzyusko kirillzyusko added 🚀 optimization You optimize something and it becomes working faster refactor You changed the code but it didn't affect functionality labels Feb 13, 2024
@kirillzyusko kirillzyusko marked this pull request as ready for review February 13, 2024 08:33
@kirillzyusko kirillzyusko merged commit 7d2d0a2 into main Feb 13, 2024
7 checks passed
@kirillzyusko kirillzyusko deleted the chore/remove-replicas branch February 13, 2024 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚀 optimization You optimize something and it becomes working faster refactor You changed the code but it didn't affect functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant