fix: memory leak on iOS #322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Package size report
|
kirillzyusko
added
the
📝 paper
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Fixed memory leak on iOS in paper architecture.
💡 Motivation and Context
I used strong references when specified methods as callbacks. I had to use
[weak self]in order to create a weak reference and object can be deallocated properly.I also tested Fabric, but when I keep view as simple as possible - view still doesn't call
deinit.Closes #317
📢 Changelog
iOS
[weak self]for callbacks inKeyboardMovementObserverandFocusedInputObserver;🤔 How Has This Been Tested?
Tested in XCode.
📸 Screenshots (if appropriate):
memory-leak-2.mov
no-memory-leak-trimmed.mov
📝 Checklist