Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix duplicate screen names #312

Merged
merged 2 commits into from
Dec 25, 2023
Merged

Fix duplicate screen names #312

merged 2 commits into from
Dec 25, 2023

Conversation

zoontek
Copy link
Contributor

@zoontek zoontek commented Dec 25, 2023 •
edited
Loading

📜 Description

This is a very small PR to fix an issue with the native stack screen names.

Screenshot 2023-12-25 at 20 39 00

This also solves a missing key in the ExamplesStackParamList type.

💡 Motivation and Context

It prevents a warning when running the example app.

📢 Changelog

  • Fix duplicate screen names in the native stack example

@kirillzyusko
Copy link
Owner

Amazing @zoontek
Thank you for this PR!

@kirillzyusko kirillzyusko merged commit f95f249 into kirillzyusko:main Dec 25, 2023
5 checks passed
@zoontek zoontek deleted the fix-duplicate-screen-name branch December 25, 2023 22:13
@kirillzyusko kirillzyusko self-assigned this Dec 27, 2023
@kirillzyusko kirillzyusko added the example Anything related to example project label Dec 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@kirillzyusko kirillzyusko

Labels
example Anything related to example project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zoontek @kirillzyusko