Skip to content

fix: use install_modules_dependencies to fix compilation issues on RN 0.73 with Fabric #308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 28, 2024

Conversation

kirillzyusko
Copy link
Owner

@kirillzyusko kirillzyusko commented Dec 23, 2023

📜 Description

Started to use install_modules_dependencies in .podspec.

💡 Motivation and Context

It's vital to use install_modules_dependencies because it simplifies integration process (this function is shipped in RN, so RN team cares about internal deps that could be provided to the project).

So it means that we don't need to specify it manually anymore and instead we can rely on the implementation provided by the package.

However we need to keep in mind, that this function is available only from RN 0.71, so if we support RN < 0.71 we need to have fallback code.

The other aspect that was discovered during the implementation is the fact that this function was broken on RN 0.72 + Swift + New Arch combination, but with latest RN release it's not broken anymore (that's the reason why I updated a RN dependency in this PR - to verify that it actually works as expected).

Closes #371

📢 Changelog

JS

  • updated RN to 0.72.11

iOS

  • modified .podspec file to use install_modules_dependencies function.

🤔 How Has This Been Tested?

Tested manually in reproduction example + via CI.

📝 Checklist

  • CI successfully passed

@kirillzyusko kirillzyusko added the 🍎 iOS iOS specific label Dec 23, 2023
@kirillzyusko kirillzyusko self-assigned this Dec 23, 2023
Copy link
Contributor

github-actions bot commented Dec 23, 2023

📊 Package size report

Current size Target Size Difference
134769 bytes 134695 bytes 74 bytes 📈

@kirillzyusko kirillzyusko changed the title fix: use install_modules_dependencies to fix compilation issues on … fix: use install_modules_dependencies to fix compilation issues on RN 0.73 with Fabric Dec 23, 2023
@kirillzyusko kirillzyusko added 🏭 fabric Changes specific to new (fabric/jsi) architecture CI CI (github actions) labels Dec 23, 2023
@kirillzyusko
Copy link
Owner Author

Seems like fabric build is failing for RN < 0.73. I asked a question here lottie-react-native/lottie-react-native#1139 (comment) 👀

@kirillzyusko kirillzyusko removed the CI CI (github actions) label Dec 29, 2023
@kirillzyusko
Copy link
Owner Author

kirillzyusko commented Jan 2, 2024

We need to wait for new RN 0.72 version (see facebook/react-native#42075) to be released and after that we can update RN version in RNKC and merge this PR.

@kirillzyusko kirillzyusko force-pushed the fix/rn-0.73-new-arch-ios branch from 9c31ae9 to 00f2625 Compare February 28, 2024 18:27
@kirillzyusko kirillzyusko marked this pull request as ready for review February 28, 2024 18:47
@kirillzyusko kirillzyusko added the deps update Upgrade dependencies of the project label Feb 28, 2024
@kirillzyusko kirillzyusko merged commit a303db7 into main Feb 28, 2024
@kirillzyusko kirillzyusko deleted the fix/rn-0.73-new-arch-ios branch February 28, 2024 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deps update Upgrade dependencies of the project 🏭 fabric Changes specific to new (fabric/jsi) architecture 🍎 iOS iOS specific
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compilation Error on iOS with Fabric and useFrameworks: 'static'
1 participant