refactor: get rid off deprecated useWorkletCallback
#290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kirillzyusko
added
the
refactor
📊 Package size report
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Migrated
useWorkletCallbacktouseCallback+workletdirective.💡 Motivation and Context
useWorkletCallbackis deprecated from3.6.1version. Usage of deprecated API is a risky thing, because it can be removed at any point of time, so I migrated it back touseCallback+worklet.Also I updated
reanimatedto3.6.1version and removed unused@ts-expect-errordirectives.Closes #289
📢 Changelog
JS
reanimatedto version3.6.1;useWorkletCallback->useCallback+workletdirective;@ts-expect-errordirectives;e2e
AwareScrollViewKeyboardClosedscreenshot (it should have scroll back when keyboard gets hidden);🤔 How Has This Been Tested?
Tested manually on API 28 emulator + e2e tests;
📝 Checklist