refactor: rename FocusedInputLayoutObserver
-> FocusedInputObserver
#282
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Renamed
FocusedInputLayoutObserver
toFocusedInputObserver
.💡 Motivation and Context
I'm planning to extend library functionality. Soon apart of observing layout of focused input I'll also do other things (such as observing the text that user is typing).
Creating another class is kind of very expensive thing, because the functionality of these two classes will be toughly bound to each other (for example when observing text-value we'll need to sync-up layout - and it's a part of current
FocusedInputLayoutObserver
).So taking it into consideration I decided to rename
FocusedInputLayoutObserver
class to make it more generic.📢 Changelog
iOS
FocusedInputLayoutObserver.swift
file toFocusedInputObserver.swift
;FocusedInputLayoutObserver
toFocusedInputObserver
.Android
FocusedInputLayoutObserver.kt
file toFocusedInputObserver.kt
;FocusedInputLayoutObserver
toFocusedInputObserver
.🤔 How Has This Been Tested?
Tested manually on Pixel 3a (API 33, emulator).
📝 Checklist