Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: rename FocusedInputLayoutObserver -> FocusedInputObserver #282

Merged
merged 1 commit into from
Nov 26, 2023

Conversation

kirillzyusko
Copy link
Owner

📜 Description

Renamed FocusedInputLayoutObserver to FocusedInputObserver.

💡 Motivation and Context

I'm planning to extend library functionality. Soon apart of observing layout of focused input I'll also do other things (such as observing the text that user is typing).

Creating another class is kind of very expensive thing, because the functionality of these two classes will be toughly bound to each other (for example when observing text-value we'll need to sync-up layout - and it's a part of current FocusedInputLayoutObserver).

So taking it into consideration I decided to rename FocusedInputLayoutObserver class to make it more generic.

📢 Changelog

iOS

  • renamed FocusedInputLayoutObserver.swift file to FocusedInputObserver.swift;
  • renamed all references of FocusedInputLayoutObserver to FocusedInputObserver.

Android

  • renamed FocusedInputLayoutObserver.kt file to FocusedInputObserver.kt;
  • renamed all references of FocusedInputLayoutObserver to FocusedInputObserver.

🤔 How Has This Been Tested?

Tested manually on Pixel 3a (API 33, emulator).

📝 Checklist

  • CI successfully passed

@kirillzyusko kirillzyusko added 🤖 android Android specific 🍎 iOS iOS specific refactor You changed the code but it didn't affect functionality labels Nov 25, 2023
@kirillzyusko kirillzyusko self-assigned this Nov 25, 2023
Copy link
Contributor

📊 Package size report

Current size Target Size Difference
80173 bytes 80166 bytes 7 bytes 📈

@kirillzyusko kirillzyusko merged commit c94c5e3 into main Nov 26, 2023
16 checks passed
@kirillzyusko kirillzyusko deleted the refactor/rename-focused-input-layout-observer branch November 26, 2023 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖 android Android specific 🍎 iOS iOS specific refactor You changed the code but it didn't affect functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant