Skip to content

Commit

Permalink
refactor: comments re-phrasing
Browse files Browse the repository at this point in the history
  • Loading branch information
kirillzyusko committed Dec 3, 2024
1 parent df0628a commit 8bde230
Showing 1 changed file with 2 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,8 @@ class ModalAttachedWatcher(
// go through main `rootView`, so we don't need to stop main
// callback - otherwise keyboard transitions will not be animated
this.callback()?.suspend(true)
// attaching callback to Modal on Android < 12 can cause ghost animation, see: https://github.com/kirillzyusko/react-native-keyboard-controller/issues/714
// attaching callback to Modal on Android < 12 can cause ghost animations, see: https://github.com/kirillzyusko/react-native-keyboard-controller/pull/718
// and overall attaching additional callbacks (if animation events go through the main window) is not necessary
ViewCompat.setWindowInsetsAnimationCallback(rootView, callback)
ViewCompat.setOnApplyWindowInsetsListener(eventView, callback)

Expand Down

0 comments on commit 8bde230

Please sign in to comment.