-
Notifications
You must be signed in to change notification settings - Fork 23
2019_04_09_Kirby Guild Meeting Summary
Anders Skarby edited this page Apr 10, 2019
·
2 revisions
This page contains a meeting summary from the Kirby Guild meeting, held on April 9th, 2019.
- Completed
- Badge completed (Tommy)
- Segmented Chip with horizontal scroll (“Team India”)
- In Progress
- Marvin (and Jakob) is working on a component overview (similar to what Ionic has)
- Martin and Smajo have been working on Modal, and aa pull request has landed for it.
- Smajo has been working on Calendar
- A Web-component, rendered on the web, and on {N} it’s rendered within a WebView.
- Updated this morning (April 9th, 2019)
- We’ll get Segmented Control and Segmented Chip Control “out there”, and then later revisited them, and:
- Unify them in a single control, that will have a property decided what their visual expression will be.
- We’ll consider if it needs a new name (maybe align with Ionic and call it segment, or bootstrap and call it ButtonGroup)
- Colors
- Done, but hex values may change
- Spacing / Gutters
- Done -Elevation
- Done
- Typography
- Use the one in Zeplin’s Styleguide, not the one in the dashboard (that’s for UX’ers only)
- Since all of the above are now “Done” (from the UX’ers perspective), we need to start implementing them into Kirby.
We didn't get around to talk about naming (in regards to atoms / molecules) or testing, even though that was part of the agenda. We'll take this "online".
Follow this link for instructions on how to get support.
Have a look at the contribution guidelines.
The following articles can help you become a good contributor. They document our toughts and opinions on contribution related topics.
- The Good: Issue
- The Good: Branch
- The Good: Commit
- The Good: Self-review
- The Good: Pull-request
- The Good: Test
Other ways of doing things are not wrong - however a project of this size requires consistency in the way we cooperate to be manageable.
Ultimately it will help you save some time getting from a new issue to a merged PR.