chore: --experimental-use-server-side-upsert document #983
+55
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chihiro-adachi
changed the title
chihiro-adachi
changed the title
chihiro-adachi
requested review from
tasshi-me and
shabaraba
and removed request for
a team
hisasami
reviewed
Jan 15, 2025
|
|
||
| We have implemented the `--experimental-use-server-side-upsert` option, which executes the record import command using [the upsert option of the bulk record update API](https://cybozu.dev/ja/kintone/docs/rest-api/records/update-records/) | ||
|
|
||
| Previously, cli-kintone implemented its own upsert mode, but by using `--experimental-use-server-side-upsert`, there is a possibility that the performance of the record import command will improve. |
There was a problem hiding this comment.
Previously, cli-kintone implemented its own upsert mode,
↓
以前からあるcli-kintone独自のupsert機能があります、という意図の表現でしょうか？
Cli-kintone has been running with its own upsert modeやCli-kintone has had its own upsert modeが自然に聞こえるかもです。
（そもそも主語がcli-kintoneなので、人が主語となるべきimplementの動詞とマッチしていなさそう）
There was a problem hiding this comment.
@hisasami
なるほど、ご提案いただいた文章に修正してみます！
ありがとうございます〜
tasshi-me
reviewed
Jan 15, 2025
| --update-key レコード番号 \ | ||
| --experimental-use-server-side-upsert | ||
| ``` | ||
|
|
There was a problem hiding this comment.
安定性が確認できたらデフォルトオンにする予定というのも書いておいて良さそうです。
There was a problem hiding this comment.
@tasshi-me
ありがとうございますー
一文追加しました。
855f943
Co-authored-by: tasshi / Masaharu Tashiro <[email protected]>
tasshi-me
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
What
--experimental-use-server-side-upsertHow to test
Checklist
pnpm lintandpnpm teston the root directory.