Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add CliKintoneTest-54,55 #592

Merged
merged 3 commits into from
Nov 28, 2023
Merged

test: add CliKintoneTest-54,55 #592

merged 3 commits into from
Nov 28, 2023

Conversation

tuanphamcybozu
Copy link
Contributor

Why

Adding e2e test cases.

What

  • adding test cases to verify --fields option
    • field within a Table
    • field code of a Table

How to test

pnpm build
pnpm test:e2e

Checklist

  • Read CONTRIBUTING.md
  • Updated documentation if it is required.
  • Added/updated tests if it is required. (or tested manually)
  • Passed pnpm lint and pnpm test on the root directory.

@tuanphamcybozu tuanphamcybozu requested review from a team and hung-cybo and removed request for a team November 27, 2023 06:59
hung-cybo
hung-cybo approved these changes Nov 28, 2023
View reviewed changes
Copy link
Contributor

@hung-cybo hung-cybo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hung-cybo hung-cybo merged commit d411d23 into main Nov 28, 2023
@hung-cybo hung-cybo deleted the test/CliKintoneTest-54-55 branch November 28, 2023 03:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hung-cybo hung-cybo hung-cybo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tuanphamcybozu @hung-cybo