Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add new test cases CliKintoneTest-62-63-64 #588

Merged
merged 6 commits into from
Nov 29, 2023
Merged

test: add new test cases CliKintoneTest-62-63-64 #588

merged 6 commits into from
Nov 29, 2023

Conversation

hung-cybo
Copy link
Contributor

Why

Adding e2e test cases.

What

  • adding test cases to verify --encoding option
    • utf8 encoding
    • sjis encoding
    • unsupported character code

How to test

pnpm build
pnpm test:e2e

Checklist

  • Read CONTRIBUTING.md
  • Updated documentation if it is required.
  • Added/updated tests if it is required. (or tested manually)
  • Passed pnpm lint and pnpm test on the root directory.

@hung-cybo hung-cybo requested review from a team and tuanphamcybozu and removed request for a team November 23, 2023 10:08
tasshi-me
tasshi-me reviewed Nov 24, 2023
View reviewed changes
Copy link
Member

@tasshi-me tasshi-me left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added one comment about a step definition.
Please give me your opinion.

features/step_definitions/import.ts Outdated Show resolved Hide resolved
tasshi-me
tasshi-me approved these changes Nov 29, 2023
View reviewed changes
Copy link
Member

@tasshi-me tasshi-me left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tasshi-me tasshi-me merged commit 04f8471 into main Nov 29, 2023
@tasshi-me tasshi-me deleted the test/CliKintoneTest-62-63-64 branch November 29, 2023 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tasshi-me tasshi-me tasshi-me approved these changes

@tuanphamcybozu tuanphamcybozu Awaiting requested review from tuanphamcybozu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hung-cybo @tasshi-me