Remove outdated CSS vendor prefix #430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested in #429 (comment):
This pull request includes a change to the resources/sass/_base.scss file, removing the redundant CSS vendor prefixes for the
::selectionpseudo-element styles.CSS improvements:
Removed redundant
::selectionstyles for::-moz-selectionand::-webkit-selectionto simplify the code.These vendor prefixes have not been required for a long time, according to caniuse:
https://caniuse.com/?search=selection
I argue that vendor prefixes must not even be directly included in the Sass code, instead we should introduce tools such as Autoprefixer into our tooling to do this based on Browserslist data.
Lastly, as kint is mainly a development tool rather than production tool, I argue it's fair to assume the dev would be running on a fairly recent browser that would not be outdated beyond just a couple of versions.