-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
terminal: m caps #596
Open
nick1udwig
wants to merge
3
commits into
v0.10.0
Choose a base branch
from
hf/terminal-m-caps
base: v0.10.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
terminal: m caps #596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it's an oversight that this doesn't currently work -- i'm surprised this code does not allow it: kinode/kinode/packages/app-store/app-store/src/utils.rs Lines 342 to 391 in 28664d7
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
m
doesn't send caps with messages, #579 #581Solution
Attach caps that were issued by a given process and that are held by terminal to
m
Requests.Testing
Docs Update
None
Notes
This still doesn't resolve #579 & #581 completely. The issue that remains is that there is no way for a process to pass a userspace cap to terminal. We either need to:
grant_capabilities
to allow non-messaging
caps to be granted,terminal:terminal:sys
api that allows processes to give it capabilities.