added more jobs and mocks to the zembleBull #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 6646791 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
robertherber
requested changes
Oct 2, 2024
| setTimeout(async () => this.#worker(job, { logger: zembleContext.logger }), 0) | ||
| return job | ||
| } | ||
|
|
||
| async remove(jobId: string) { |
There was a problem hiding this comment.
Don't we want to use jest.fn()/mock() to be able to "spy" on it (i.e. to see if it was called, with which arguments etc)?
Actually it might be nice to wrap all the functions with mock() so it's always possible.. :) As you see here it's possible to both provide an implementation and wrap it in mock() (or jest.fn())
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two new jobs in ZembleBullQeueue and more mock functions ti ZembleQueueMock